Unnecessary else
Categories:
Created by Microsoft, Described by waldo
Description
else
should not be used when the last action in the then
part is an exit
, break
, skip
, quit
, error
.
Bad code
procedure SomeProcedure()
begin
if IsAdjmtBinCodeChanged() then
Error(AdjmtBinCodeChangeNotAllowedErr, ...)
else
Error(BinCodeChangeNotAllowedErr, ...);
end;
Good code
procedure SomeProcedure()
begin
if IsAdjmtBinCodeChanged() then
Error(AdjmtBinCodeChangeNotAllowedErr, ...)
Error(BinCodeChangeNotAllowedErr, ...);
end;
Last modified September 22, 2023: Merge pull request #234 from microsoft/TheDoubleH-patch-2 (6659139)
by Henrik Helgesen