Unnecessary else

Tags:
Categories:

Created by Microsoft, Described by waldo

Description

else should not be used when the last action in the then part is an exit, break, skip, quit, error.

Bad code

    procedure SomeProcedure()
    begin
        if IsAdjmtBinCodeChanged() then
            Error(AdjmtBinCodeChangeNotAllowedErr, ...)
        else
            Error(BinCodeChangeNotAllowedErr, ...);
    end;

Good code

    procedure SomeProcedure()
    begin
        if IsAdjmtBinCodeChanged() then
            Error(AdjmtBinCodeChangeNotAllowedErr, ...)
        Error(BinCodeChangeNotAllowedErr, ...);
    end;
Last modified February 24, 2022: Removed Discussion Links. Using new Theme solution. (fb17dc96) by Henrik Helgesen